dev is set on virtual_ipaddress when use_vmac is enabled

[ghost]

Context:

puppet-keepalived/templates/vrrp_instance.erb

Line 139 in 4bdd57a

<%= ip %> dev <%= @virtual_ipaddress_int || @interface %>

The current template does set dev for a virtual_ipaddress in any case. But this is not needed nor in every case desired.

Given the (working excerpt) of a VI:

vrrp_instance VI_1 {
  interface                 lan0
  state                     BACKUP
  virtual_router_id         1
  priority                  100
  advert_int                1
  garp_master_delay         0

  garp_master_refresh       60


  use_vmac
  vmac_xmit_base

  virtual_ipaddress {
    10.100.2.254/32
  }

  mcast_src_ip 10.100.2.252
}

The virtual_ipaddress will be assigned to vrrp.1@lan0.

But this puppet module sets

• if using only interface

  virtual_ipaddress {
    10.100.2.254/32 dev lan0
  }

• and virtual_ipaddress_int to vrrp.1@lan0 does not work as intended.

I propose to just drop adding dev to the virtual_ipaddress except the user explicit stats it. At least on Linux, the kernel handles this just fine.

[ghost]

Sorry I published the draft and now need to edit the issue multiple times.

[ghost]

Pardon me, this is already fixed in https://github.com/voxpupuli/puppet-keepalived/tree/v2.2.0