Make masking Service['firewalld'] optional #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarrientos
force-pushed
the
firewalld_mask
branch
from
258e6a3
to
ae9872e
Compare
|
LGTM The fact that |
|
Ready to be reviewed. |
figless
pushed a commit
to figless/puppet-nftables
that referenced
this pull request
Aug 25, 2021
9246192 Merge pull request voxpupuli#16 from cernops/icmp 587e522 Merge pull request voxpupuli#20 from cernops/firewalld_mask ae9872e Make masking Service['firewalld'] configurable 79e9a23 Move ICMP stuff to separate classes git-subtree-dir: code git-subtree-split: 9246192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users might be completely removing
firewalldfrom the system when using this module. Unfortunately masking an unexisting systemd unit leads to errors when applying the catalog:This patch allows module users to disable the unit masking which is enough to get a clean Puppet run if there's no trace of firewalld in the system.