-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to work with Puppet5 #406
Comments
Is there something specific that doesn't work, or do you just mean updating the metadata.json to mark the module as puppet 5 compatible? |
Not sure if anything doesn't work. Based on the dependencies I would think everything would work with Puppet5, but we should update the metadata and try it. |
hope this module stays puppet4 compatible |
@c33s There are no plans to remove puppet 4 compatibility. |
I use the module with Puppet 5.2.0 and don't have any problems. The only thing is that a warning is thrown that the use of hiera_hash is deprecated but this is purely cosmetic. So what this issue is requesting is that the metadata.json is updated to reflect support of Puppet 5. Integration tests are already running against Puppet 5. |
@joekohlsdorf Thanks for the feedback and PR. |
Can we upgrade this repo to work with Puppet5?
The text was updated successfully, but these errors were encountered: