Officially support Ubuntu 18.04

[baurmatt]

Pull Request (PR) description

This PR adds official (metadata.json + Tests) for Ubuntu 18.04.

This Pull Request (PR) fixes the following issues

Fixes #757

[baurmatt]

Hmm this is strange:

    Port "15672"

ubuntu1804-64-1 17:09:00$ /bin/sh -c ss\ -tnl4\ \|\ grep\ --\ \\\ \\\\\\\*:15672\\\

ubuntu1804-64-1 executed in 0.01 seconds

root@ubuntu1804-64-1:/# netstat -nlp | grep 15672
tcp        0      0 0.0.0.0:15672           0.0.0.0:*               LISTEN      2410/beam.smp

The problem seems to be that its trying to grep for *:15672 due to this line in specinfra https://github.com/mizzy/specinfra/blob/7fcb239eb5b4dca705663ca342c405c41a5ffc0c/lib/specinfra/command/module/ss.rb#L17

I guess the output off ss changed.

Ubuntu 18.04:

root@ubuntu1804-64-1:/# ss -tnl4 | grep 15672
LISTEN   0         128                 0.0.0.0:15672            0.0.0.0:*
root@ubuntu1804-64-1:/# which ss
/bin/ss
root@ubuntu1804-64-1:/# dpkg -S /bin/ss
iproute2: /bin/ss
root@ubuntu1804-64-1:/# dpkg -l | grep iproute2
ii  iproute2                    4.15.0-2ubuntu1                   amd64        networking and traffic control tools

Ubuntu 16.04:

root@ubuntu1604-64-1:/# ss -tnl4 | grep 15672
LISTEN     0      128          *:15672                    *:*
root@ubuntu1604-64-1:/# which ss
/bin/ss
root@ubuntu1604-64-1:/# dpkg -S /bin/ss
iproute2: /bin/ss
root@ubuntu1604-64-1:/# dpkg -l | grep iproute2
ii  iproute2                   4.3.0-1ubuntu3.16.04.4                amd64        networking and traffic control tools

[baurmatt]

This is most certainly the reason for this https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=1267c0b924de0297510efd48f8f849af774be369

[wyardley]

Good find. It would be better if we can avoid just marking the tests of the service listening as pending — want to try and get this fixed upstream?

[baurmatt]

@wyardley Just opened a issue for that ;) Take a look, perhaps you have a good idea of how we can fix this :)

[wyardley]

@baurmatt I can restart Travis, but not sure this will work until the bundle gets updated with newer serverspec version (which may have to come from https://github.com/voxpupuli/modulesync_config)

Opening and closing won't re-run Travis, but force-pushing will.

[baurmatt]

Oh really? Since when is that? Worked for me a couple of weeks ago pretty well.

Travis should update the specinfra gem as we do not pin it directly.

[wyardley]

@baurmatt Travis also seems to be having some issues right now, not running on any of the new PRs :/

You're right about specinfra; forgot that Gemfile.lock wasn't committed when I looked locally.

Also, seems like the build is passing.

[wyardley]

@baurmatt: can you open a separate PR to add it to docker sets in https://github.com/voxpupuli/puppet-rabbitmq/blob/master/.sync.yml ?

[bastelfreak]

FYI: The travis issues were caused by a full queue of jobs.

[baurmatt]

I keep forgetting about modulesync :( Openend up #767 to make it persistent.