Can't create an expressión filter with more than one 'else if'

[amateo]

Hi,

I need to create a ruleset with a rule with an expression with more than just one else if. Somethin like:

if $hostname == ["sip", "proxysipint", "proxysipintb" ] then {
  set $.filename = "kam-int.log";

    }
else if $hostname == ["sipext", "proxysipext" ] then {
  set $.filename = "kam-ext.log";

    }
else if $hostname == ["pbxum", "pbxum1", "pbxum1b"] then {
  set $.filename = "ast-core.log";

    }

So, my code is like:

  - expression_filter:
      filter:
        if:
          expression: '$hostname == ["sip", "proxysipint", "proxysipintb" ]'
          tasks:
            - set:
                '$.filename': '"kam-int.log"'
        'else if':
          expression: '$hostname == ["sipext", "proxysipext" ]'
          tasks:
            - set:
                '$.filename': '"kam-ext.log"'
        'else if':
          expression: '$hostname == ["pbxum", "pbxum1", "pbxum1b"]'
          tasks:
            - set:
                '$.filename': '"ast-core.log"'

the problem with this hiera is that I have to use the same else if key for two different hash elements, so the second overrides the first.

I've been looking for a way to create such an expression, but as the template for an expression is:

<%- |
$filter_name,
$conditionals
| -%>
# <%= $filter_name %>
<%- $conditionals.each |$conditional, $options| { -%>
  <%- if $conditional == 'else' { -%>
<%= $conditional %> {
  <%- } else { -%>
<%= "${conditional} ${options['expression']} then" %> {
  <%-}-%>
<%- $options['tasks'].each |$task| { -%>
<%= epp('rsyslog/tasks.epp', { 'tasks' => $task }) -%>
<%-}-%>
}
<%}-%>

I can't find any way to do it, because the conditional clause is taken always from the key of the element in the hash.

Is there any way to create such config?

[amateo]

I have found that coding the yaml like:

  - expression_filter:
      filter:
        if:
          expression: '$hostname == ["sip", "proxysipint", "proxysipintb" ]'
          tasks:
            - set:
                '$.filename': '"kam-int.log"'
        "# else if 1\nelse if":
          expression: '$hostname == ["sipext", "proxysipext" ]'
          tasks:
            - set:
                '$.filename': '"kam-ext.log"'
        "# else if 2\nelse if":
          expression: '$hostname == ["pbxum", "pbxum1", "pbxum1b"]'
          tasks:
            - set:
                '$.filename': '"ast-core.log"'

worarounds the problem, but I can't find a better way

[dhollinger]

I'll take a look at what I can do. I have some ideas.

[dhollinger]

@amateo I pushed an update to master that changes how the expression filter YAML is formatted a little. It is still compatible with current formats, it just is designed to address the issue you ran into. Your workaround gave me the idea to name the conditions rather than try and rely on users putting the if, else if, and else in there.

see https://github.com/voxpupuli/puppet-rsyslog#expression-based-filters for some updated examples

I am planning on pushing up a release to the puppet forge either tonight or tomorrow if you'd rather wait for that than pull from git.

[amateo]

Thank you @dhollinger, I'll try it as soon as the new release is published.

[amateo]

@dhollinger, have you released it in the forge?

[dhollinger]

@amateo Not yet, will be before the end of the day (local time)

[dhollinger]

@amateo The release should be live now

[amateo]

Ok. Thank you.