Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Are you open to using inifile instead of toml-rb? #119

Closed
genebean opened this issue Feb 15, 2019 · 6 comments
Closed

[question] Are you open to using inifile instead of toml-rb? #119

genebean opened this issue Feb 15, 2019 · 6 comments
Labels

Comments

@genebean
Copy link
Contributor

The telefraf config can easily be managed using inifile resources instead of requiring the toml-rb gem... are you open to a PR for that? I just wanted to check prior to doing the work.

@bastelfreak
Copy link
Member

Hi. Yes, I think inifile is a better approach for this :)

@SimonHoenscheid
Copy link
Member

@genebean This sounds interesting, can you give a short hint, how you wabnt to accomplish this using the inifile ressource?

@dhoppe
Copy link
Member

dhoppe commented Mar 13, 2019

I would also like to store the variables in data/*.yaml and use the function create_ini_settings().

But the file telegraf.conf is not a real .ini file and the parameters indent_width, section_prefix and section_suffix can not work miracles either.

For example, the input plugin for Jolokia has an additional level.

I am not sure how this could work.

@genebean
Copy link
Contributor Author

After looking at this more and taking into account all the different things that can be set I have to admit that I actually don't think my initial idea will work. Each of the settings can indeed be created via inifile but making something that works for all the nested options doesn't seem doable in the time I can commit. Sorry :(

@genebean
Copy link
Contributor Author

Ideally we need a standalone toml type and provider for Puppet

@dhoppe
Copy link
Member

dhoppe commented May 19, 2020

I agree with that. Some plugins use "Array of Tables" and this is really hard to realize with inifile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants