zabbix::agent doesn't pass $zabbix_version to zabbix::repo

[adamancini]

Using this module out of the box to set up zabbix in our environment, we installed 2.4 on all of our up to date distributions, but when adding in a check to send 2.2 out to ubuntu Lucid hosts, it seems when using in our node definition:

if ( $lsbdistcodename == 'lucid' ) {
    $zabbix_version = '2.2'
  } else {
    $zabbix_version = '2.4'
  }

class { 'zabbix::agent':
      server         => '10.0.0.118',
      listenip       => '0.0.0.0',
      hostname       => $::fqdn,
      zabbix_version => $zabbix_version
    }

the 2.2 string is never actually sent to zabbix::repo to set up the repository.

Using notify, I traced $zabbix_version from our node definition, into zabbix::agent, but when zabbix::repo is called it uses the default value defined in zabbix::params regardless of $zabbix_version.

I was able to work around this in our environment by using the resource-style declaration in zabbix::agent

# Check if manage_repo is true.
  if $manage_repo {
    class {'zabbix::repo': zabbix_version => $zabbix_version }
    Package['zabbix-agent'] {require => Class['zabbix::repo']}
  }

[adamancini]

Edit: Nevermind, this has already been fixed in the latest release.