zabbix::userparameters::data doesn't notify correctly the zabbix-agent service

[ljeromets]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.5.13
• Ruby:
• Distribution: Ubuntu 16.04
• Module version: 6.7.0

How to reproduce (e.g Puppet code you use)

Use the zabbix::userparameter::data in hiera

zabbix::userparameter::data: 'userparameter_diskstats': source: puppet:///modules/zabbix/linux/userparameter_diskstats.conf script: puppet:///modules/zabbix/linux/script/lld-diskstats.py script_dir: '/usr/local/bin' script_ext: '.py'

Remove the userparameter created and run puppet
rm -rf /etc/zabbix/zabbix_agentd.d/userparameter_diskstats.conf root@fxxxxxx1:~# puppet agent -t -v Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Loading facts Info: Caching catalog for xxxxxxx Info: Applying configuration version '1557145863' Notice: /Stage[main]/Zabbix::Userparameter/Zabbix::Userparameters[userparameter_diskstats]/File[/etc/zabbix/zabbix_agentd.d/userparameter_diskstats.conf]/ensure: defined content as '{md5}40f177eff830a6798d3d656e5d22f8b4' (corrective) Notice: Applied catalog in 2.56 seconds

What are you seeing

The userparameter is created but the zabbix-agent is not notified.

What behaviour did you expect instead

Expect than when the userparameter change, the service should be always notify.

Output log

Any additional information you'd like to impart

The fix is to rename the line "$agent_servicename = $zabbix::agent::agent_servicename" by "$agent_servicename = $zabbix::agent::servicename" in the file https://github.com/voxpupuli/puppet-zabbix/blob/master/manifests/userparameters.pp#L77