Test for CentOS 7 current failing due to bug in docker

[baurmatt]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: All
• Ruby: All
• Distribution: CentOS 7.7
• Module version: Current master

How to reproduce (e.g Puppet code you use)

Take a look at the failing Travis test in master (https://travis-ci.org/voxpupuli/puppet-zabbix/jobs/633797254)

What are you seeing

  Error: /Stage[main]/Zabbix::Agent/Service[zabbix-agent]/ensure: change from 'stopped' to 'running' failed: Systemd start for zabbix-agent failed!
  journalctl log for zabbix-agent:
  -- Logs begin at Tue 2020-01-07 13:06:46 UTC, end at Tue 2020-01-07 13:10:16 UTC. --
  Jan 07 13:08:46 centos7-64-1 systemd[1]: Starting Zabbix Agent...
  Jan 07 13:08:46 centos7-64-1 zabbix_agentd[2119]: Starting Zabbix Agent [centos7-64-1]. Zabbix 2.4.8 (revision 59539).
  Jan 07 13:08:46 centos7-64-1 systemd[1]: New main PID 2119 does not belong to service, and PID file is not owned by root. Refusing.
  Jan 07 13:08:46 centos7-64-1 systemd[1]: New main PID 2119 does not belong to service, and PID file is not owned by root. Refusing.
  Jan 07 13:08:46 centos7-64-1 zabbix_agentd[2119]: using configuration file: /etc/zabbix/zabbix_agentd.conf
  Jan 07 13:08:46 centos7-64-1 zabbix_agentd[2119]: agent #0 started [main process]
  Jan 07 13:08:46 centos7-64-1 zabbix_agentd[2123]: agent #4 started [listener #3]
  Jan 07 13:08:46 centos7-64-1 zabbix_agentd[2121]: agent #2 started [listener #1]
  Jan 07 13:08:46 centos7-64-1 zabbix_agentd[2122]: agent #3 started [listener #2]
  Jan 07 13:08:46 centos7-64-1 zabbix_agentd[2120]: agent #1 started [collector]
  Jan 07 13:10:16 centos7-64-1 systemd[1]: zabbix-agent.service start operation timed out. Terminating.
  Jan 07 13:10:16 centos7-64-1 zabbix_agentd[2120]: Got signal [signal:15(SIGTERM),sender_pid:1,sender_uid:0,reason:0]. Exiting ...
  Jan 07 13:10:16 centos7-64-1 zabbix_agentd[2119]: One child process died (PID:2120,exitcode/signal:1). Exiting ...
  Jan 07 13:10:16 centos7-64-1 zabbix_agentd[2122]: Got signal [signal:15(SIGTERM),sender_pid:1,sender_uid:0,reason:0]. Exiting ...
  Jan 07 13:10:16 centos7-64-1 zabbix_agentd[2119]: Zabbix Agent stopped. Zabbix 2.4.8 (revision 59539).
  Jan 07 13:10:16 centos7-64-1 systemd[1]: Failed to start Zabbix Agent.
  Jan 07 13:10:16 centos7-64-1 systemd[1]: Unit zabbix-agent.service entered failed state.
  Jan 07 13:10:16 centos7-64-1 systemd[1]: zabbix-agent.service failed.
  Notice: /Stage[main]/Zabbix::Agent/Service[zabbix-agent]: Triggered 'refresh' from 4 events
  Notice: /Stage[main]/Zabbix::Agent/Zabbix::Startup[zabbix-agent]/File[/etc/systemd/system/zabbix-agent.service]/ensure: defined content as '{md5}fa59ac4864ca40b2e62476f02a327a04'
  Info: /Stage[main]/Zabbix::Agent/Zabbix::Startup[zabbix-agent]/File[/etc/systemd/system/zabbix-agent.service]: Scheduling refresh of Exec[systemctl-daemon-reload]
  Notice: /Stage[main]/Systemd::Systemctl::Daemon_reload/Exec[systemctl-daemon-reload]: Triggered 'refresh' from 1 event
  Info: Class[Zabbix::Agent]: Unscheduling all events on Class[Zabbix::Agent]
  Info: Stage[main]: Unscheduling all events on Stage[main]
  Info: Creating state file /opt/puppetlabs/puppet/cache/state/state.yaml
  Notice: Applied catalog in 97.84 seconds

What behaviour did you expect instead

Tests runs sucessfully.

Output log

Any additional information you'd like to impart

Problems seems to be the systemd version bundled with CentOS 7.7 and a current docker version. See docker/for-linux#835 and moby/moby#38749

@ekohl seems to have fixed this for puppet-proxysql with pinning the CentOS 7 docker image to 7.6.1810. I will provide a PR for this module which does the same.