Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure which PuppetDB endpoints are allowed in the /query page #475

Closed
volans- opened this issue Jul 11, 2018 · 0 comments · Fixed by #477
Closed

Allow to configure which PuppetDB endpoints are allowed in the /query page #475

volans- opened this issue Jul 11, 2018 · 0 comments · Fixed by #477

Comments

@volans-
Copy link
Contributor

volans- commented Jul 11, 2018

Right now there is just a global switch to enable or disable the /query endpoint: ENABLE_QUERY.
It would be nice to have an easy way to allow only a sub-selection of the available PuppetDB endpoints.
For example the catalog endpoint might return secrets from the host's catalog and this could be considered unsafe and to be forbidden in a given environment. But at the same time it would be very useful to allow fact queries. And this is my use case.

An additional configuration parameter that allow to specify the list of enabled PuppetDB endpoints that could be queried should be easy enough to add, increasing a lot Puppetboard flexibility.

volans- added a commit to volans-/puppetboard that referenced this issue Jul 18, 2018
Allow to configure which PuppetDB endpoints are allowed in the /query
page, adding the ENABLED_QUERY_ENDPOINTS configuration variable, that
if set restricts the allowed endpoints to query. If not set the previous
behaviour is kept, allowing all PuppetDB endpoints to be queried, if the
ENABLE_QUERY configuration is True.

Closes: voxpupuli#475
volans- added a commit to volans-/puppetboard that referenced this issue May 27, 2019
Allow to configure which PuppetDB endpoints are allowed in the /query
page, adding the ENABLED_QUERY_ENDPOINTS configuration variable, that
if set restricts the allowed endpoints to query. If not set the previous
behaviour is kept, allowing all PuppetDB endpoints to be queried, if the
ENABLE_QUERY configuration is True.

Closes: voxpupuli#475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant