Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Controlling the web server via Settings screen #1645

Open
wants to merge 5 commits into
base: 10.8.1
Choose a base branch
from

Conversation

YellowLabrador
Copy link

No description provided.

@jsm174
Copy link
Contributor

jsm174 commented Apr 15, 2024

This is great!

If possible, really would like to stick to PLOG for everything and not try to do #define swaps.

#ifdef __ANDROID__
#define LOG_TAG "WebServer"
#include "../../../src/utils/AndroidLog.h"
#define WEBLOGE ALOGE
#define WEBLOGI ALOGI
#else
#define WEBLOGE PLOGE.printf
#define WEBLOGI PLOGI.printf
#endif

@YellowLabrador
Copy link
Author

ok. I will have a PR for separating the PLOG initialization from main.cpp so it can be called from both the web server and main.cpp. That will allow for PLOG usage even when a table is not running, which is the case here. After that PR is done I will update this one to use PLOG directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants