Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking not working #98

Open
moimfeld opened this issue Aug 8, 2022 · 0 comments
Open

Masking not working #98

moimfeld opened this issue Aug 8, 2022 · 0 comments

Comments

@moimfeld
Copy link
Contributor

moimfeld commented Aug 8, 2022

Hi @michael-platzer

I remember that you told me at one point that the masking for some instructions does not work. Nevertheless I open this issue to create an overview of all instructions for which the masked version is not supported.

Issue

I have found the following instructions for which Vicuna does not support masking (i.e. Vicuna computes a wrong result if they are masked):

# All reduction instructions
vredsum.vs
vredmaxu.vs
vredmax.vs
vredminu.vs
vredmin.vs
vredand.vs
vredor.vs
vredxor.vs

# Min/Max instructions
vmin(u).(vv|vx)
vmax(u).(vv|vx)

I will extend the list if I find further instructions where the masked version is not supported. If you know some instructions where Vicuna does not support the masked version, could you please add them below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant