Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flags to support the newly added languages #768

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Update flags to support the newly added languages #768

merged 2 commits into from
Apr 13, 2024

Conversation

hyblocker
Copy link
Contributor

This PR updates the flags so that the recently added languages (to user bios) have their appropriate flags.

yue (Yue Chinese) and tws (Teochew Min) evaluate to ?? resulting in the unknown flag, as I am unsure on which specific flag should be used for these.

@Natsumi-sama
Copy link
Member

Ah! thanks, I was dreading having to deal with this. I have no idea what to do about the missing flags I'll ask some people that might know.

@Natsumi-sama
Copy link
Member

My Taiwanese friend said;

Yue Chinese for Traditional Chinese
Teochew Min for Simplify Chinese
Chinese flag for both is fine

@hyblocker
Copy link
Contributor Author

I've mapped them to the Chinese flag now then.

@Natsumi-sama Natsumi-sama merged commit 0827fbd into vrcx-team:master Apr 13, 2024
Natsumi-sama pushed a commit to Natsumi-sama/VRCX that referenced this pull request Apr 13, 2024
* Update flags to support the newly added languages

* Map yue and tws to Chinese as per the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants