Make a function that checks that the DR artifact to use matches, in terms of metadata, the DCAE one

[vrodriguezf]

In GitLab by @vrodriguezf on Oct 14, 2020, 13:30

There can be problems if, for example, the DR wants to use an artifact with 15 variables, but the associated DCAE has been trained with an artifact with 10 variables. The inputs wouldn't match.

There's already a scaffolding of the function check_compatibility in the DR notebook:

%nbdev_export
def check_compatibility(dr_ar:TSArtifact, dcae_ar:TSArtifact):
    "TODO: Function to check that the artifact used by the DCAE and the artifact that is \
    going to be passed through the DR are compatible"
    ret = dr_ar.metadata['TS']['vars'] == dcae_ar.metadata['TS']['vars']
    # Check that the dr artifact is not normalized
    return ret

For now it just checks that the variables used are the same (in number and names). There are other things that has to be checked here such as:

• the resample period used in both artifacts. (that is in TS.freq inside the metadata.
• Whether the DR artifact has issing values or not (that is in TS.has_missing_values, it has to be false)

[vrodriguezf]

In GitLab by @lgs on Oct 19, 2020, 10:30

created merge request !4 to address this issue

[vrodriguezf]

In GitLab by @lgs on Oct 19, 2020, 10:30

mentioned in merge request !4

[vrodriguezf]

In GitLab by @lgs on Oct 19, 2020, 10:57

created merge request !5 to address this issue

[vrodriguezf]

In GitLab by @lgs on Oct 19, 2020, 10:57

mentioned in merge request !5

[vrodriguezf]

In GitLab by @lgs on Oct 19, 2020, 11:15

mentioned in commit f787c23

[vrodriguezf]

In GitLab by @lgs on Oct 19, 2020, 11:17

created merge request !6 to address this issue

[vrodriguezf]

In GitLab by @lgs on Oct 19, 2020, 11:17

mentioned in merge request !6

[vrodriguezf]

In GitLab by @lgs on Oct 19, 2020, 11:56

mentioned in merge request !7