Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit deleted objects #8

Closed
vsemionov opened this issue Aug 22, 2017 · 2 comments
Closed

Limit deleted objects #8

vsemionov opened this issue Aug 22, 2017 · 2 comments

Comments

@vsemionov
Copy link
Owner

vsemionov commented Aug 22, 2017 •
edited
Loading

Enforce the limit when deleting an object.
Also, when listing deleted objects, return 206 if the limit is reached.
@vsemionov
Copy link
Owner Author

vsemionov commented Aug 25, 2017 •
edited
Loading

Implemented in 81e3f59.
Return http 206 partial response when listing deleted objects and deletion limit is reached for the parent(s), including the aggregate note list. If feasible (i.e. not requiring a per-parent request) only return it if the first deleted object is deleted after the since parameter.
The deleted route will be moved to NestedViewSet/UserNoteViewSet for two reasons: 1) prevent a dependency between the limit and sync mixins and 2) an overridden route is not recognized by the rest framework

@vsemionov
Copy link
Owner Author

Resolved in 77b7479.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vsemionov