Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code in comment make the highlighting less happy #15

Closed
fponticelli opened this issue Feb 20, 2017 · 6 comments
Closed

code in comment make the highlighting less happy #15

fponticelli opened this issue Feb 20, 2017 · 6 comments
Labels

Comments

@fponticelli
Copy link

See attached image.

screen shot 2017-02-20 at 12 55 29 pm

@Gama11
Copy link
Member

Gama11 commented Feb 20, 2017

Hm, that looks pretty off even before the comment... Latest vshaxe? What theme are you using?

Can you provide the source to copy-paste for easy testing?

@fponticelli
Copy link
Author

1.3.3 of VSCode and the theme was a stock dark. With other themes the function keyword is fine but the section after the comment is broken in the same way.

@Gama11
Copy link
Member

Gama11 commented Feb 20, 2017

Can you provide the source to copy-paste for easy testing?

@fponticelli
Copy link
Author

fponticelli commented Feb 20, 2017

  static function refreshSlug(slug: Slug) {
    var id = slug.toString(),
        url = js.Browser.window.location.href, // '${Loc.msg.site_url}/#${slug.toString()}';
        title = js.Browser.document.title;
    try {
      (untyped __js__("DISQUS")).reset({
        reload: true,
        config: function () {
          var self = js.Lib.nativeThis;
          self.page.identifier = id;
          self.page.url = url;
          self.page.title = title;
        }
      });
    } catch(e: Dynamic) {
      haxe.Timer.delay(refreshSlug.bind(slug), 25);
    }
  }

@Gama11
Copy link
Member

Gama11 commented Feb 20, 2017

Thanks, I can reproduce it. :)

I guess you're using the "Dark" theme rather than Dark+, which is why it looked off to me.

@Gama11 Gama11 added the bug label Feb 20, 2017
@Gama11
Copy link
Member

Gama11 commented Feb 20, 2017

This is actually just about comments (or conditional compilation statements for that matter) not being highlighted in multi-var decls.

@Gama11 Gama11 closed this as completed in 071ed9f Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants