Add hex colors detection

[RblSb]

Works out of box it seems. Please bind with vscode option by yourself, i have no idea about correct server handling. Some description suggestion:

"haxe.enableColorsDetection": {
	"type": "boolean",
	"default": true,
	"markdownDescription": "Try to detect `0xAA/RRGGBB` colors in code and show color pickers"
}

(also null access fix for updateActiveEditorPackage)

[Gama11]

[RblSb]

Sigh, i dont know how to compile this after merge/rebase and npm install.

[AlexHaxe]

Sigh, i dont know how to compile this after merge/rebase and npm install.

did you perform a lix download?

edit: also I had to rename languageserver's TextDocument to HxTextDocument to avoid name clashes with TextDocument type from externs

[RblSb]

Yes (also called from npm postinstall), this is all i get now:

/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
/vshaxe/server/src/haxeLanguageServer/import.hx:6: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
server/shared/haxeLanguageServer/LanguageServerMethods.hx:5: characters 8-56 : Type not found : languageServerProtocol.textdocument.TextDocument
server/shared/haxeLanguageServer/LanguageServerMethods.hx:41: characters 76-87 : Type not found : DocumentUri

There is ~/haxe/haxe_libraries/language-server-protocol/3.17.0-rc.20/github/55bb2720c6d728b4e4d4ad49bb2a069add8f6438/src/languageServerProtocol/textdocument/TextDocument.hx

[RblSb]

npx lix run vshaxe-build -t language-server -t language-server-tests shows same error as CI (still hard to fix with broken ide, will try to redownload repo tomorrow and copy branch code, idk)
npx lix run vshaxe-build -t vshaxe --debug shows same TextDocument error from outside (on this and on main branches).

[AlexHaxe]

it seems like you are running everything from vshaxe project.
I haven't updated vshaxe's dependencies, so it still uses 3.15.3 of language server protocol, while haxe-languageserver expects 3.17.0.

[RblSb]

Thanks, with opened subproject things are working.

[RblSb]

There is editor.colorDecorators setting btw, not sure if specific haxe option is required, if there is "[haxe]": {"editor.colorDecorators": false}. Maybe can be annoying for someone to disable this way.

[Gama11]

No, we don't want to add a redundant setting if it can be done with a built-in one.

[AlexHaxe]

both (global and Haxe specific) setting work fine according to my quick tests.
so... we good to merge?

[Gama11]

I haven't updated vshaxe's dependencies, so it still uses 3.15.3 of language server protocol, while haxe-languageserver expects 3.17.0.

Why not? They should be kept in sync, otherwise you can't build vshaxe with a current server version...

[Gama11]

@RblSb I noticed that we turn lowercase hex into uppercase hex in the color editor. We should try to preserve casing if possible.

[RblSb]

Do you want to keep casing for every character or only low/high new string case based on first character after 0x?

[Gama11]

Good question, not sure about mixed casing... I don't think you even can fully preserve casing there, after all, a position that was previously a number might turn into a letter after changing the color in the editor, and then you have nothing to base the decision on. So it's probably best to base it on the first letter.