Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use --server-connect #393

Closed
3 tasks done
nadako opened this issue Nov 7, 2019 · 2 comments
Closed
3 tasks done

use --server-connect #393

nadako opened this issue Nov 7, 2019 · 2 comments

Comments

@nadako
Copy link
Member

nadako commented Nov 7, 2019 •
edited by Gama11
Loading

vshaxe/haxe-language-server#42

  • properly close the socket in close
  • choose between StdioConnection and SocketConnection based on Haxe version
  • figure out what to do with haxeshim
nadako referenced this issue in vshaxe/haxe-language-server Nov 7, 2019
@nadako
close sockets properly, handle haxe process exit before it connects (…
6192b76 
…e.g. due to invalid args)
@nadako nadako changed the title use --wait-connect use --server-connect Nov 7, 2019
@Gama11
Copy link
Member

Gama11 commented Jan 19, 2020 •
edited
Loading

We now use --server-connect by default if:

  • we're using a non-preview-build of Haxe 4.0 or 4.1+
  • there's no .haxerc file (it's not a lix project)

We can remove the second condition / hack once lix-pm/haxeshim#49 is resolved.

@Simn
Copy link
Member

Simn commented Jan 19, 2020

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nadako @Simn @Gama11