Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hiding WinSparkle GUI when doing an automatic update #168

Open
thdouk opened this issue Mar 6, 2018 · 3 comments
Open

Support for hiding WinSparkle GUI when doing an automatic update #168

thdouk opened this issue Mar 6, 2018 · 3 comments

Comments

@thdouk
Copy link

thdouk commented Mar 6, 2018

Hi @vslavik,
Thank you for creating and maintaining this project, it is really useful.
I am implementing a feature where the client wants to do all the updates silently, without any GUI interactions. I managed to do so by using ManualAutoInstallUpdateChecker, and created a patch in my fork where you can hide all the GUI windows through a new function: win_sparkle_set_hide_updater_windows(int hide).

I was wondering if you would be interested in such a functionality for the project, or similar (That is when performing an automatic update, hide completely the Winsparkle GUI and perform the installation).
Glad to provide a PR if you like the idea :)

@vslavik
Copy link
Owner

vslavik commented Mar 6, 2018

I'm open to having support for totally silent updating — I can see the appeal.

But doing it by hiding windows (as opposed to not creating them in the first place) seems like a gross hack. So if you really mean that, I'd rather not. But would, again, welcome proper support for this.

P.S. Email (which is trivial to find, this using git and all) is better suited than issues to questions or discussions.

@darkgnostic
Copy link

Seconding this. It is pretty useful in closed systems, where no user interaction is needed/required.

@vslavik
Copy link
Owner

vslavik commented Apr 27, 2018

@darkgnostic Please don't spam with "me too" comments — you have an upvote button for that. As I said, I'll gladly merge a well-executed PR. Submitting one is a great way to "second this" if this is something you care about (my apps have visible UI, I don't need this and so am unlikely to work on this sort of thing myself).

Repository owner deleted a comment from darkgnostic Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants