Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Support regular NVMe read/write (0x01, 0x02) in OCSSD 2.0 spec #51

Closed
lovers-under-moon opened this issue Apr 20, 2021 · 2 comments

Comments

@lovers-under-moon
Copy link

image

FEMU OCSSD2.0 do not support NVMe read/write (0x01, 0x02).

image

@huaicheng
Copy link
Contributor

The regular NVMe READ/WRITE commands are not really meaningful for directly accessing an OC device (I might miss something). For the SPDK+OCSSD2.0 case, does the SPDK FTL soly rely on NVMe READ/WRITE to function? (no use of the VECTOR read/write/erase at all?)

SPDK might expect an "NVME_SUCCESS" or other types of return values instead of "NVME_DNR" for the regular read/write commands, or it might have issued the I/O and mgmt commands in an order that's not the same as LightNVM+kernel-NVMe driver, thus FEMU is not able to correctly handle it.

PRs are welcome, otherwise, I work on this when I have time (timing not guaranteed).

@huaicheng
Copy link
Contributor

Let me know if above patch works for you. Feel free to re-open the issue. I will mark it closed for now.

yaOoo830 pushed a commit to yaOoo830/FEMU that referenced this issue Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants