Feat: Adds tokens to ProductGrid
#127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes Best Practices section * Creates `ProductGrid` tokens * Creates ProductGrid doc Co-Authored-By: Eduardo Formiga <eduardo.formiga@gmail.com> * Updates Changelog * Fixes `ProductGrid` description typo Co-authored-by: Lucas Feijó <lucas.portela@vtex.com.br> * Hides props that are not working for now * Improves BestPractices descriptions Co-authored-by: Eduardo Formiga <eduardo.formiga@gmail.com> Co-authored-by: Lucas Feijó <lucas.portela@vtex.com.br>
renatamottam
added
Documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-b77d539--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit b77d539
|
…om/vtex-sites/gatsby.store into feat/theming-product-grid-fsss-391
lucasfp13
approved these changes
Jun 29, 2022
hellofanny
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Approving because it looks the same as vtex-sites/nextjs.store#144 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Ported from
next.storerepo: Adds tokens to ProductGrid #144This PR applies the new Theming structure to
ProductGrid: new scoped tokens linked to global ones.How does it work?
This PR uses local variables to parameterize the
ProductGridproperties, then connects these scoped tokens to the global ones.Tokens list can be visualized in the storybook.
How to test it?
ProductGridcomponent and its related components should look just as it was before these changes.Checklist
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.Documentation