Feat/add attachments to cartitem #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit d1da4ea
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-d1da4ea--gatsby.preview.vtex.app |
icazevedo
force-pushed
the
feat/add-attachments-to-cartitem-id
branch
from
370e065
to
44ca175
Compare
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
tlgimenes
reviewed
May 25, 2022
| item.price, | ||
| serializeAdditionalProperty(item.itemOffered), | ||
| ] | ||
| .filter(Boolean) |
There was a problem hiding this comment.
do we need to filter? If addicionalProperty is null, than the final key will be ...::null which doesn't impact the final key. What do you think?
tlgimenes
reviewed
May 25, 2022
tlgimenes
approved these changes
May 25, 2022
tlgimenes
approved these changes
May 25, 2022
emersonlaurentino
approved these changes
May 25, 2022
icazevedo
force-pushed
the
feat/add-attachments-to-cartitem-id
branch
from
1d5fd78
to
b479400
Compare
icazevedo
force-pushed
the
feat/add-attachments-to-cartitem-id
branch
from
581becd
to
41eb7a6
Compare
|
Deployment failed with the following error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Updates the starter to take attachments into account when calculating the item ID: vtex/faststore#1304
How does it work?
The implementation uses the same logic as FastStore API's
getIdfunctionHow to test it?
Add items to the cart and check the browser storage (indexed db). It should work just like before, but with id separator as
::instead of the previous:(this change was introduced to match the logic inside FastStore API)Checklist
You may erase this after checking them all ;)
Added an entry in the
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.Added the PR number with the PR link at the entry in the
CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR description
Updated the Storybook - if applicable.
Added a label according to the PR goal -
Breaking change,Enhancement,BugorChore.Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g.,
ComponentNamecomponent.Identified the function or parameter in the PR - If applicable. E.g.,
useWindowDimensionshook.For documentation changes, ping @carolinamenezes or @Mariana-Caetano to review and update the changes.