Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dx interview solution #170

Closed
wants to merge 3 commits into from
Closed

Dx interview solution #170

wants to merge 3 commits into from

Conversation

victorhmp
Copy link
Contributor

What's the purpose of this pull request?

Considering the context, what is the problem we'll solve? Where in VTEX's big picture our issue fits in? Write a tweet about the context and the problem itself.

How does it work?

Tell us the role of the new feature, or component, in its context.

How to test it?

Describe the steps with bullet points. Is there any external reference, link, or example?

References

Spread the knowledge: is this any content you used to create this PR that is worth sharing?

Extra tip: add references to related issues or mention people important to this PR may be good for the documentation and reviewing process

Checklist

You may erase this after checking them all ;)

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

- Add two new fields to the `StoreProduct` type: `unitMultiplier` and `measurementUnit`
- Create resolvers for both of them.
`unitMultiplier` and `measurementUnit`.
@vercel
Copy link

vercel bot commented Jul 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ❌ Failed (Inspect) Jul 11, 2022 at 9:40PM (UTC)

@vtex-sites
Copy link

vtex-sites bot commented Jul 11, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-c7e9a20--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit c7e9a20

@vtex-sites
Copy link

vtex-sites bot commented Jul 11, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit c7e9a20

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@victorhmp victorhmp closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant