-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds new tokens to Skeleton
#171
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6e2d583
to
4002844
Compare
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-171--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 2cfbe7a
|
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! I left just one comment. But we won't add a story for Skeleton?
We will, I'm already working on them 🔛 |
4002844
to
3fbd4f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing Job, @lucasfp13!
You also included ProductShelf
🎉
Sometimes I'm in doubt if we need some tokens, especially the ones with width
or height
with 100%
or 0
values.
src/components/skeletons/FilterSkeleton/filter-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/FilterSkeleton/filter-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/FilterSkeleton/FilterSkeleton.stories.mdx
Outdated
Show resolved
Hide resolved
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
...ponents/skeletons/ProductTilesSkeleton/ProductTileSkeleton/product-tile-skeleton.module.scss
Outdated
Show resolved
Hide resolved
|
||
# Skeletons | ||
|
||
This feature improves the store's experience and perceived performance through loading placeholders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we classifying skeletons components as a feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice question! I also wonder about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed this with @renatamottam, and it makes sense to be a feature for her, also I agree that it is ok so then we group all skeletons
4ea3489
to
f80fcdb
Compare
0da3e8c
to
bb90f0e
Compare
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/FilterSkeleton/filter-skeleton.module.scss
Outdated
Show resolved
Hide resolved
afb3dc7
to
914fd26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What's the purpose of this pull request?
This PR intends to apply new tokens to
Skeleton
and its related components, based on the new Theming structure: new scoped tokens linked to global ones.It also uses FastStore UI's
Skeleton
component and renamesSkeletonElement
toSkeleton
for a better code understanding/legibility.How does it work?
This PR uses local variables to parameterize the
Skeleton
and its related components' properties, then connects these scoped tokens to the global ones.How to test it?
These changes should not affect the skeletons' behavior. It can be tested through browser developer tools, applying a network throttling to simulate, for instance, a slow 3g connection.
skeleton.mov
Checklist
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#4)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation