CheckForDoubleRead false possitive in WebSocketConnectionRfc6455.cs

[weweilep]

If you send an empty string as the payload over the stream, ReadMessage/ReadString and its variants will throw an exception from CheckForDoubleRead line 253

if (CurrentHeader != null)
    throw new WebSocketException("There is an ongoing message that is being readed from somewhere else");

I haven't taken the time to research the cause, but I'm guessing the header doesn't get cleared after a 0 payload message.

This can be reproduced by sending an empty string to the EchoServer example.

[weweilep]

I should note, it does appear to send/receive the empty packet, but it appears the next poll has the previous header retained.

[vtortola]

Hi,

Thank you for taking the time to report this, I could reproduce the problem as you explained and I am confident I fixed it in this commit I just did: 0205272

I will take some days till I release a new NuGet package, in the mean time you can use this 2.1.2 pre-release or the source directly (as I suspect you are already doing).

Let me know if you have any further issue.

Cheers.

[weweilep]

Yes, this appears to correct the issue in all my test cases.

Thanks for the prompt response and update!

[vtortola]

No problem 👍