Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack 3.*, bump relevant dependencies (fix #751) #891

Merged
merged 1 commit into from Sep 30, 2017

Conversation

LinusBorg
Copy link
Contributor

This PR updates all webpack-related dependencies to their latest versions.

It also deactivates the code responisble for triggering page reload when html-webpack-plugin sees that index.html has been changed, because according to jantimon/html-webpack-plugin#680 this is currently buggy and interferes with HMR.

Commenting out this code makes HMR work again.

We will keep an eye on this issue and re-enable this once the problem in html-webpak-plugin has been resolved.

@LinusBorg LinusBorg mentioned this pull request Sep 1, 2017
@LinusBorg LinusBorg modified the milestone: 1.1.0 Sep 1, 2017
@robwierzbowski
Copy link
Contributor

robwierzbowski commented Sep 2, 2017

I just updated to Webpack 3 on a project scaffolded using this repo. My diffs were:

Update to Webpack 3.5.5: https://github.com/robwierzbowski/rw-vue/commit/d6787debfcd8738ad6bcced81ada5ce5a0caf7eb
Fix the resulting Uglify issue: https://github.com/robwierzbowski/rw-vue/commit/09f58c3790a168faefdc0f86af492cb6a473553f

More changes than your current diff, just wanted to let you know.

@LinusBorg
Copy link
Contributor Author

Thanks, will check that out!

Much apprechiated.

@robwierzbowski
Copy link
Contributor

No problem.

@maxmilton
Copy link

Since we're making the step to webpack 3 should we also now use webpack.optimize.ModuleConcatenationPlugin()? Or perhaps that should be a separate PR?

@Finrod927
Copy link

Using these versions and this fix for few weeks now, no issues.
Just need a manual fresh "page reload" sometimes, I don't know why, it's probably related to my project.

@sudo-suhas
Copy link
Contributor

@LinusBorg I upgraded a project to webpack 3 and while it isn't a through check, things were working as expected. Hot-reloading too for src code.

@LinusBorg LinusBorg merged commit 8d215b4 into develop Sep 30, 2017
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this pull request Oct 13, 2017
@LinusBorg LinusBorg deleted the feature/webpack_3 branch October 16, 2017 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants