Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make __ob__ unenumerable #149

Merged
merged 3 commits into from
Oct 31, 2019
Merged

fix: make __ob__ unenumerable #149

merged 3 commits into from
Oct 31, 2019

Conversation

wjw99830
Copy link
Contributor

@wjw99830 wjw99830 commented Sep 27, 2019

Make __ob__ unenumerable to avoid stack overflow while some code traverse properties of reactive object internally like vue-echarts and JSON.stringify().

src/reactivity/reactive.ts Outdated Show resolved Hide resolved
@liximomo liximomo merged commit 1672b6e into vuejs:master Oct 31, 2019
@vue-bot
Copy link

vue-bot commented Oct 31, 2019

Hey @wjw99830, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

pikax pushed a commit to pikax/vue-function-api that referenced this pull request Apr 19, 2020
* fix: make __ob__ unenumerable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants