Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): fix tying issues in #428 #444

Merged
merged 2 commits into from
Jul 18, 2020
Merged

fix(type): fix tying issues in #428 #444

merged 2 commits into from
Jul 18, 2020

Conversation

antfu
Copy link
Member

@antfu antfu commented Jul 18, 2020

  • Omit some Vue attributes to override with our custom ones
  • Fix ExtractFunctionPropType to accept general functions

@antfu antfu requested a review from pikax July 18, 2020 06:25
@antfu
Copy link
Member Author

antfu commented Jul 18, 2020

I am going to merge it and make a release for now. If you find any problems, we can revert them later :)

@antfu antfu merged commit 98c7041 into vuejs:master Jul 18, 2020
@antfu antfu deleted the fix/type-428 branch July 18, 2020 07:40
sapphi-red added a commit to sapphi-red/composition-api that referenced this pull request Jul 20, 2020
@sapphi-red sapphi-red mentioned this pull request Jul 20, 2020
antfu pushed a commit that referenced this pull request Jul 20, 2020
* fix: some types set by PropType was any

reverts #444

* fix: Function PropType become undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant