Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reactivity): unwrap value when using set #722

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

pikax
Copy link
Member

@pikax pikax commented Jun 4, 2021

fix #721

When using set if the object is not reactive it won't execute the unwrapping as per expected on a reactive object, in vue 2 every object used is expected to be reactive by default so I believe is safe to assume that if you calling set we will want to unwrap the value if is a ref

@pikax pikax requested review from posva and antfu June 4, 2021 11:59
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ref not unwrapping other refs set with set on Node
3 participants