Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime-vapor): component attrs #124

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

ubugeeei
Copy link
Member

@ubugeeei ubugeeei commented Feb 9, 2024

close #48

TODO:

  • attrs
  • functional without declaration

- [ ] fallthrough attributes
-> move to #125

I felt that the design for Fallthrough Attributes needed some consideration, so I made it a separate issue.

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit fcb0809
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/65c6537532499d000835fbc0
😎 Deploy Preview https://deploy-preview-124--vapor-repl.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit fcb0809
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/65c6537693d7f20008803dfb
😎 Deploy Preview https://deploy-preview-124--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ubugeeei ubugeeei marked this pull request as draft February 9, 2024 14:44
Copy link

github-actions bot commented Feb 9, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80.1 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 47.2 kB 16.1 kB 14.5 kB
runtime-dom.global.prod.js 91.2 kB 34.7 kB 31.3 kB
runtime-vapor.global.prod.js 34.7 kB (+318 B) 13.2 kB (+107 B) 12.1 kB (+94 B)
vue-vapor.global.prod.js 79.3 kB (+318 B) 27.8 kB (+110 B) 25.1 kB (+76 B)
vue.global.prod.js 148 kB 53.9 kB 48.2 kB

Usages

Name Size Gzip Brotli
createApp 51.5 kB 20 kB 18.3 kB
createSSRApp 54.8 kB 21.4 kB 19.5 kB
defineCustomElement 53.8 kB 20.8 kB 18.9 kB
vapor 34.9 kB (+330 B) 13.3 kB (+117 B) 12.2 kB (+115 B)
overall 65.2 kB 25.1 kB 22.8 kB

@ubugeeei ubugeeei assigned ubugeeei and unassigned ubugeeei Feb 9, 2024
@ubugeeei ubugeeei marked this pull request as ready for review February 9, 2024 16:32
@ubugeeei ubugeeei requested a review from sxzz February 9, 2024 16:36
@ubugeeei ubugeeei mentioned this pull request Feb 9, 2024
28 tasks
@sxzz sxzz force-pushed the main branch 7 times, most recently from 8605d92 to 8a2a2ac Compare February 10, 2024 04:53
@sxzz sxzz merged commit 52311fa into main Feb 10, 2024
9 checks passed
@sxzz sxzz deleted the ubugeeei/feat/runtime-component-attrs branch February 10, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Attrs
2 participants