Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler-vapor): functional custom directive support updated hooks #58

Merged
merged 4 commits into from
Dec 13, 2023
Merged

feat(compiler-vapor): functional custom directive support updated hooks #58

merged 4 commits into from
Dec 13, 2023

Conversation

baiwusanyu-c
Copy link
Member

@baiwusanyu-c baiwusanyu-c commented Dec 12, 2023 •
edited
Loading

TODO: unit test

I will rewrite a more complete directive unit test

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 88.2 kB 33.6 kB 30.3 kB
runtime-vapor.global.prod.js 19 kB (+10 B) 7.24 kB (+2 B) 6.65 kB (+2 B)
vue-vapor.global.prod.js 54.6 kB (+10 B) 18.3 kB (+3 B) 16.6 kB (+11 B)
vue.global.prod.js 145 kB 52.7 kB 47.1 kB

Usages

Name Size Gzip Brotli
createApp 48.8 kB 19.1 kB 17.5 kB
createSSRApp 52 kB 20.5 kB 18.7 kB
defineCustomElement 51.2 kB 19.9 kB 18.2 kB
vapor 18.9 kB (+10 B) 7.25 kB (+3 B) 6.67 kB (+5 B)
overall 62.2 kB 24 kB 21.9 kB

@baiwusanyu-c baiwusanyu-c marked this pull request as draft December 12, 2023 09:15
@baiwusanyu-c @sxzz
Update packages/runtime-vapor/src/directive.ts
58d4e12 
Co-authored-by: 三咲智子 Kevin Deng <sxzz@sxzz.moe>
@baiwusanyu-c baiwusanyu-c marked this pull request as ready for review December 12, 2023 09:48
@baiwusanyu-c
Copy link
Member Author

relate：#59

@sxzz sxzz merged commit 5e681b5 into main Dec 13, 2023
5 checks passed
@sxzz sxzz changed the title feat: functional custom directive support updated hooks feat(compiler-vapor): functional custom directive support updated hooks Dec 13, 2023
@sxzz sxzz deleted the bwsy/feat/directive-func branch December 13, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baiwusanyu-c @sxzz