Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): chained computeds lost reactivity #11170

Closed
wants to merge 1 commit into from

Conversation

wanghanzhen
Copy link

When getting dirty and _dirtyLevel === DirtyLevels.MaybeDirty_ComputedSideEffect_Origin, it's supposed to execute resetTracking before return true. Otherwise, computed after that cannot be tracked and ends up losing reactivity.

Fix #11169

@Doctor-wu
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jun 18, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@wanghanzhen
Copy link
Author

wanghanzhen commented Jun 19, 2024

Hold on, just found a Maximum recursion error in my project after adding resetTracking😨
At present, the minimum reproduction has not been found yet.

@Doctor-wu
Copy link
Member

@wanghanzhen could you try to provide reproduce, I think it's necessary to add resetTracking here to align behaviour with others dirty level

@Doctor-wu
Copy link
Member

Doctor-wu commented Jun 20, 2024

@wanghanzhen Submitted #11183 for fixing both #11169 and #11181, reused your test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chain computed lost reactivity when computed effect happens
3 participants