Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v-show does not take effect with custom directive on parent #2333

Closed
adamberecz opened this issue Oct 8, 2020 · 3 comments
Closed

v-show does not take effect with custom directive on parent #2333

adamberecz opened this issue Oct 8, 2020 · 3 comments
Labels
🐞 bug Something isn't working

Comments

@adamberecz
Copy link

Version

3.0.0

Reproduction link

https://jsfiddle.net/9es7j4q1/2/

Steps to reproduce

  1. Add any custom directive to a parent component
  2. Use v-show directive in the child's root DOM
  3. If the value of v-show is false the child is still shown
  4. (change v-show to v-if and the child will not be shown)

What is expected?

Visually hide child element with v-show even if parent has a custom directive

What is actually happening?

The child element still appears
@LinusBorg LinusBorg added the 🐞 bug Something isn't working label Oct 8, 2020
@unbyte
Copy link
Contributor

unbyte commented Oct 8, 2020

@LinusBorg have tested on latest version https://github.com/vuejs/vue-next/tree/fbd198fbfe2f87c3c15a63d9770d00bf3fc9c142 , child element is hidden correctly

@KaelWD
Copy link
Contributor

KaelWD commented Oct 8, 2020

Duplicate of #2298?

@yyx990803
Copy link
Member

yeah, fixed by 4d1ebb5

@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yyx990803 @LinusBorg @unbyte @adamberecz @KaelWD