Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transition): apply transition to teleport child #6548

Merged
merged 17 commits into from
Apr 25, 2024

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Aug 26, 2022

close #5836

<transition>
  <teleport to="body">
	<!-- teleport will have a transition, comment will be ignore -->
    <div>Whatever</div>
  </teleport>
</transition>

if teleport only has one root element. it will has a transition.
see playground

@JeremCafeyn
Copy link

JeremCafeyn commented Dec 14, 2022

Hi @edison1105 ,
Thanks for your work
Do you know if this one will be merge soon?

@edison1105
Copy link
Member Author

Hi @edison1105 , Thanks for your work Do you know if this one will be merge soon?

This is an enhancement to an existing feature that may not be merged as quickly

@adroslice
Copy link

What's the status on this? I'd really like to use this in a project.

@Sensanaty
Copy link

Any updates on this one? Would be a very nice QOL feature

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.8 kB (+80 B) 34.5 kB (+35 B) 31.1 kB (+25 B)
vue.global.prod.js 148 kB (+80 B) 53.8 kB (+48 B) 48 kB (-35 B)

Usages

Name Size Gzip Brotli
createApp 50.7 kB 19.8 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53 kB 20.6 kB 18.8 kB
overall 64.5 kB (+80 B) 24.9 kB (+35 B) 22.6 kB (+38 B)

Copy link

codspeed-hq bot commented Dec 14, 2023

CodSpeed Performance Report

Merging #6548 will not alter performance

Comparing edison1105:feat/5836 (fa10978) with main (a6503e3)

Summary

✅ 53 untouched benchmarks

@daaanny90
Copy link

It would be great to see this merged! 😺

@jaa134
Copy link

jaa134 commented Feb 2, 2024

Any updates on this getting merged? Seems to be going stale...

@j-hannah
Copy link

Keeping this thread alive, I'd like to see this merged as well.

@yyx990803 yyx990803 changed the base branch from main to minor April 25, 2024 07:16
@yyx990803 yyx990803 merged commit 0e6e3c7 into vuejs:minor Apr 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Transition should sniff for Teleport
8 participants