-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-core): emit TS-compatible function declaration when requested #9363
Conversation
bump :) |
Resolved the merge conflicts |
+1 This is a very much-needed fix for those who depend on newer versions of vue-loader, and who (quite understandably) don't want to disable noImplicityAny or resort to other hacky methods as described in vuejs/vue-loader#1915 It should be a necessity to generate TS code that compiles with strict compiler options enabled in 2024. |
Size ReportBundles
Usages
|
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
In our webpack setup, like in vuejs/vue-loader#1915, we're seeing
TS7006: Parameter 'n' implicitly has an 'any' type.
warnings for all of our<script type="ts" setup>
vue modules with a<style lang="less" scoped>
block in the same file.Currently, genHoists is generating the following line:
This patch adds an explicit parameter definition for the
n
parameter when valid typescript code is requested.