Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split screen feature doesn't show as expected #78

Closed
webfansplz opened this issue Dec 17, 2023 · 3 comments · Fixed by #96
Closed

Split screen feature doesn't show as expected #78

webfansplz opened this issue Dec 17, 2023 · 3 comments · Fixed by #96
Labels
bug Something isn't working client scope: devtools client

Comments

@webfansplz
Copy link
Member

/cc @alexzhang1030

image
@webfansplz webfansplz added bug Something isn't working client scope: devtools client labels Dec 17, 2023
@alexzhang1030
Copy link
Member

That's weird, I fetched the latest code just now, and split screen works well locally.

iShot_2023-12-17_19.42.15.mp4

@alexzhang1030
Copy link
Member

Split screen has a minimal size limit, should we remove it or reduce the minimal size?

@webfansplz
Copy link
Member Author

Split screen has a minimal size limit, should we remove it or reduce the minimal size?

I think it makes sense, let's remove the limit.

@alexzhang1030 alexzhang1030 mentioned this issue Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working client scope: devtools client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client): show split screen feature always
2 participants
@webfansplz @alexzhang1030