Urgent - you just broke v1.1.2! #165
Comments
|
Updating to |
|
Have you changed you babel.config.js like: https://github.com/vuejs/jsx/releases/tag/v1.2.1 ? |
|
According to https://www.npmjs.com/package/@vue/babel-preset-jsx, I enabled |
|
Exactly the same here, we have some pending deployments that fails the CI, because of that, some modules using "^1.1.2" get updated to v1.2.1, and breaks everything ! If this release brings composition-api, I guess it's a breaking change and should be labeled as v2.0.0... |
|
Hey! We're sorry this broke your projects. This is totally unintended and we will fix it asap. I unfortunately can't do anything about this myself as I don't work on this repo, but I hope to give you some workarounds for the moment: YarnUse the resolutions field in package.json: Run NPMNow, npm doesn't provide a mechanism like this out of the box. there's a package called npm-force-resolutions that does a similar thing, inspired by the yarn feature. I haven't used it myself yet, but have seen it mentioned multiple times for these kinds of scenarios, so you might want to give it a try if time is of great concern. {
"scripts": {
"preinstall": "npx npm-force-resolutions"
},
"resolutions": {
"@vue/babel-helper-vue-jsx-merge-props": "1.1.2",
"@vue/babel-plugin-transform-vue-jsx": "1.1.2",
"@vue/babel-sugar-composition-api-inject-h": "1.1.2",
"@vue/babel-sugar-composition-api-render-instance": "1.1.2",
"@vue/babel-sugar-functional-vue": "1.1.2",
"@vue/babel-sugar-inject-h": "1.1.2",
"@vue/babel-sugar-v-model": "1.1.2",
"@vue/babel-sugar-v-on": "1.1.2"
}
} |
|
Thanks for your feedback @LinusBorg, unforunately, it's not working for me on our pipeline. I did an |
|
I just re-checked the code diff and I don't see how it could affect old use cases unless you intentionally enable the So, is there any reproduction repo that I can refer to? |
|
Same thing here, Broke all jsx components, |
|
@lpj145 do you have any code sample that can reproduce the error? |
|
Just import { VLoading, VBox } from '~/vue_shareds'
export default () => <div class="row min-vh-100 align-items-center justify-content-center">
<VBox
shadow
rounded
color="white"
class="text-center px-4 py-4"
>
<VLoading>
Carregando Sintomas...
</VLoading>
</VBox>
</div>
// Or something like that
export default {
render() {
return (<div> Hello Guys</div>)
}
} |
|
@sodatea simple example of course, but, give me this error: to solve i need to put: I forgotten to put, i tried: @vue/app preset, babel-preset and jsx-preset like doc. |
|
Got it. Not related to Composition API support, but due to this one: #87 |
|
I have solved this problem, add these to package.json dependencies , delete your node_modules and run |
|
Fixed in 1.2.2 |
|
I'm really sorry for the inconvenience. I didn't realize that the PR has only taken into effect in the new version. |
v-model 也被1.2.1影响了 设置package.json： |
|
@leidenglai 有复现的代码吗？我当时写了个 test case 发现没问题，就先没改了。 |
|
|
@sodatea @leidenglai |
render() {
return (
<AComponent vModel={this.visible}>
<div class="resume-filter__wrap">
{
([1,2,3]).map(item => {
return (
<AComponent vModel={this.other}>{{item}}</AComponent>
)
})
}
</div>
</AComponent>
)
}It will be compiled to this, when vModel is not in the direct function. |
So that it can get the correct `this` scope. Partially reverts #87. Fixes #165 (comment)
So that it can get the correct `this` scope. Partially reverts #87. Fixes #165 (comment)
|
@leidenglai @toBeTheLight thanks for the reproduction! Fixed in v1.2.3 |
Hi,
All of my code that use JSX have just started to break, although the specifically target
v1.1.2, the newv1.2.1update has broken them.h is not definedHere is an example of one of our package.json file:
Here is relevant package-lock.json file extract, before the
v1.2.1update was launched.Here is an example package-lock.json file after
v1.2.1was launched. We are still referencingv1.1.2in our package.json files.It would be nice to not break the old version of the package!
The text was updated successfully, but these errors were encountered: