Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt)!: rewrite nuxt module #791

Closed
wants to merge 3 commits into from
Closed

feat(nuxt)!: rewrite nuxt module #791

wants to merge 3 commits into from

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Nov 10, 2021

This PR rewrites the Pinia+Nuxt module for best Nuxt 3 and Bridge compatibility 💛

Testing repo with published package: https://github.com/pi0/nuxt-tests/tree/pinia

Changes:

  • Add pinia as a dependency -- Nuxt modules are supposed to be standalone and provide integration out of the box
  • Migrate back to kit -- However using kit is not documented yet and might change, it will make stability much better than not using it and without it we have to inline bridge support
  • Split vue 2 (bridge) and vue 3 plugins
  • Remove deprecated ctx.pinia
  • Nuxt 2 without bridge is not supported anymore
  • Drop .$nuxt support to prefer useNuxtApp

TODO:

@tobiasdiez
Copy link

Is there something I can help with? (It's the last missing piece for my migration to bridge)

@yassilah
Copy link
Contributor

Hi! I'd love to help too if there's anything I can do 🙂

@pi0
Copy link
Contributor Author

pi0 commented Dec 14, 2021

Thanks, @yassilah @tobiasdiez 💚 PR is pending for Nuxt 3 module tooling. Expect it ready soon :)

@psycongaroo
Copy link

hope see it soon <3

@DamianGlowala
Copy link

Any chance to see this PR merged in the near future? :) Seems like the following code is never taken into account with Nuxt 2 + Bridge:

const piniaSharedStatePlugin: Plugin = ({ $pinia }) => {
    $pinia.use(({ store }) => {
        console.log("REGISTERED PLUGIN");
    });
};

export default piniaSharedStatePlugin;

@AndreyYolkin
Copy link

I understand, that you have a lot of work on Nuxt3 RC, but could you clarify the current status of this PR?

@pi0
Copy link
Contributor Author

pi0 commented Jul 8, 2022

Reworking in a new PR~> nuxt/nuxt#12596

@pi0 pi0 closed this Jul 8, 2022
@pi0 pi0 mentioned this pull request Jul 8, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants