feat!(nuxt): upgrade nuxt module #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinia-official canceled.
|
Codecov Report
@@ Coverage Diff @@
## v2 nuxt/nuxt.js#12596 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 9 9
Lines 416 416
Branches 109 109
=======================================
Hits 406 406
Misses 5 5
Partials 5 5 Continue to review full report at Codecov.
|
posva
reviewed
Jul 8, 2022
posva
reviewed
Jul 8, 2022
posva
reviewed
Jul 8, 2022
posva
reviewed
Jul 8, 2022
pi0
commented
Jul 8, 2022
pi0
commented
Jul 8, 2022
|
I force pushed because due to conflicts in pnpm-lock |
|
The types never worked on my end. It's as if vue-tsc didn't pick up the correct tsconfig so I removed them from CI |
|
Do you also get this one:
It didn't appear before... |
|
So I tested and this only works with Nuxt 3 😓
and |
|
Thanks for the review @posva. I will rebase and check last changes on bridge. |
Aareksio
reviewed
Jul 11, 2022
pi0
commented
Jul 13, 2022
BREAKING CHANGE: in Nuxt 3, `$nuxt` is no longer available in stores. This is because it was removed in Nuxt 3 and it is no longer the _context_ as it used to be. Most of the features used there, like `$fetch` are now globally available and therefore remove the need of it. You can also use [`useNuxtApp()`](https://v3.nuxtjs.org/bridge/bridge-composition-api/) when necessary.
BREAKING CHANGE: Starting on this version, `@pinia/nuxt` only works with Nuxt 2 + Bridge and Nuxt 3, it no longer works with Nuxt 2 only. This is necessary to have one single plugin that works well with the different versions of Nuxt. If you aren't using bridge with Nuxt 2, check out the [migration guide](https://v3.nuxtjs.org/bridge/overview) or pin your `@pinia/nuxt` dependency in your: ```diff - "@pinia/nuxt": "^0.2.1", + "@pinia/nuxt": "0.2.1", ``` The `$nuxt` context usage should be replaced with globals like `$fetch()` and `useNuxtApp()`. You can find more information about this in Nuxt documentation: - https://v3.nuxtjs.org/bridge/bridge-composition-api/ - https://v3.nuxtjs.org/bridge/overview
BREAKING CHANGE: `$nuxt` usage in stores defaults to type `any` unless you install the `@nuxt/types` package. This is because that package is quite heavy and can cause conflicts in projects not requiring it. Note `$nuxt` is deprecated and shouldn't be used (cf the other breaking changes notes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #791
ctx.pinianuxi typecheckfor tpyechecking modulevue-demiis removed for vue2 support since bridge is in placedefinePiniaStore()andusePinia()exposed)Breaking changes:
$piniainjection is available which can be accessed usingusePinia()(oruseNuxtApp().$pinia)$nuxtfrom store can be accessed usinguseNuxtApp()composableTo be tested: