Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): & sign doesn't remove properly #935

Merged
merged 2 commits into from
May 10, 2021
Merged

fix(query): & sign doesn't remove properly #935

merged 2 commits into from
May 10, 2021

Conversation

mattersj
Copy link
Contributor

@mattersj mattersj commented May 9, 2021

Fix #934

posva
posva approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will make some changes locally regarding the undefined in arrays

@posva posva merged commit 885bb06 into vuejs:master May 10, 2021
@posva
Copy link
Member

posva commented May 10, 2021

Ended up keeping the behavior but created multiple tests. Thanks again

@mattersj
Copy link
Contributor Author

You are welcome!

@mattersj mattersj deleted the mattersj/issue934 branch May 10, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant ampersand when trying to remove query param
2 participants
@mattersj @posva