Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version note standardization #1025

Merged
merged 5 commits into from
Jul 20, 2017
Merged

Version note standardization #1025

merged 5 commits into from
Jul 20, 2017

Conversation

MachinisteWeb
Copy link
Contributor

@MachinisteWeb MachinisteWeb commented Jul 17, 2017

Some changes we have made from French documentation.

  • Change some >= to + for consistency with API and all others Vue documentations and Vue API : http://vuejs.org/v2/api/.
  • About 2.3.0 in render-function.md, 2.3.0 should be « exclude » in the first part of sentence? No?

Feel free to not accept point that not feet your needs for English documentation.

… documentations.

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
@chrisvfritz
Copy link
Contributor

Ha, perfect timing! One of my next todos is literally:

Standardize version notes

  1. Keep New in 2.2.0 blockquotes for completely new sections, but add + (e.g. New in 2.2.0+)
  2. Move to 2.2.0+, replacing >=2.2.0
  3. Remove only (e.g. in 2.2.0+ only)

It looks like you've already done 2. Since you've also been thinking about this, what do you think about 1 and 3?

@chrisvfritz chrisvfritz changed the title [Doc EN] — Several files — Consistency changes Version note standardization Jul 17, 2017
@MachinisteWeb
Copy link
Contributor Author

MachinisteWeb commented Jul 20, 2017

Hi @chrisvfritz,

I will enhanced my PR today to include point 1 and 3 👍

You will be able to check if that include all point at end.

EDIT : It's done. I let you check. I will provide same way for others EN documentation I already manage in french and keep this convention in mind for futur others translations (and feedbacks to EN version).

… + (e.g. New in 2.2.0+)

2. Move to 2.2.0+, replacing >=2.2.0
3. Remove only (e.g. in 2.2.0+ only)

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
@chrisvfritz
Copy link
Contributor

Beautiful! 🎉

@chrisvfritz chrisvfritz merged commit 1b65952 into vuejs:master Jul 20, 2017
@MachinisteWeb MachinisteWeb deleted the consistency branch July 20, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants