Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc EN] — Several files — Consistency changes #106

Merged
merged 4 commits into from
Aug 14, 2017

Conversation

MachinisteWeb
Copy link
Contributor

@MachinisteWeb MachinisteWeb commented Jul 17, 2017

Some changes we have made from French documentation.

  • Remove tick from template because that note refer to the template option but to the template concept.
  • Add some tick for position code words.
  • "name" become name because it's a position code.
  • Nginx become nginx because it's the official documentaiton name : https://nginx.org/en/.
  • Change >= or =< to + that is more easy to read and to have consistency accross all documentations.

Feel free to not accept point that not feet your needs for English documentation.

…tion but to the template concept.

- Add some ` for position code words.
- "name" become `name` because it's a position code.
- Nginx become nginx because it's the official documentaiton name : https://nginx.org/en/.
- Change `>=` or `=<` to `+` that is more easy to read and to have consistency accross all documentations.

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
@MachinisteWeb
Copy link
Contributor Author

Ready to Merge

All others merges are done: see vuejs/v2.vuejs.org#1025 planned by @chrisvfritz

What can I do to allows this one to be merged ?

@chrisvfritz
Copy link
Contributor

@haeresis Pinging me works. I wasn't set up to watch this repo, but now I am. 🙂 The only changes I would request are to keep NPM capitalized and Nginx titlecased, following the convention we settled on for the English version of the core docs.

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
@MachinisteWeb
Copy link
Contributor Author

Yeah, it's true @chrisvfritz. I remember, you have choose to keep them. It's done !

« Bon pour moi »

@chrisvfritz
Copy link
Contributor

Pour moi aussi! 🙂

@chrisvfritz chrisvfritz merged commit 0a98cb9 into vuejs:master Aug 14, 2017
@MachinisteWeb MachinisteWeb deleted the consistency branch August 24, 2017 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants