Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting breaks with question marks in Vue template attributes #3

Closed
mattjneuber opened this issue Nov 9, 2016 · 3 comments
Closed

Comments

@mattjneuber
Copy link

<template>
	<element :statechanged="(a == b) ? x : y"></element>
	<span :class="{'thing': true}"></span>
</template>

produces this output

Removing the ? from the expression immediately fixes the highlighting after it.

@octref octref added the bug label Nov 9, 2016
@octref
Copy link
Member

octref commented Nov 9, 2016

Thanks for reporting. Will take a look after work.

@octref
Copy link
Member

octref commented Nov 10, 2016

Upstream bug tracked at microsoft/vscode#15289
The last double quote get parsed as JavaScript double quote, so VSCode thought everything after it is a JavaScript string.

@octref
Copy link
Member

octref commented Dec 18, 2016

I just published a new version 0.1.1 including the fix.

However, this problem no longer exists on latest Insider (still repro on stable), so I guess they updated the JS grammar and fixed the problem. I'll look into it and see if I can also adopt that grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants