Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go to definition in TypeScript within a .vue file jumps to unrelated sections #741

Closed
3 tasks done
DanielRosenwasser opened this issue Mar 24, 2018 · 2 comments · Fixed by #748
Closed
3 tasks done

Go to definition in TypeScript within a .vue file jumps to unrelated sections #741

DanielRosenwasser opened this issue Mar 24, 2018 · 2 comments · Fixed by #748
Labels
feature-request

Comments

@DanielRosenwasser
Copy link
Contributor

  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ

Info

  • Platform: Windows
  • Vetur version: 0.11.7
  • VS Code version: 1.21.1
@DanielRosenwasser DanielRosenwasser changed the title Go to definition in .vue files jumps to unrelated sections Go to definition in TypeScript within .vue files jumps to unrelated sections Mar 24, 2018
This was referenced Mar 24, 2018
Closed
Closed
@DanielRosenwasser DanielRosenwasser changed the title Go to definition in TypeScript within .vue files jumps to unrelated sections Go to definition in TypeScript within a .vue file jumps to unrelated sections Mar 24, 2018
@HerringtonDarkholme
Copy link
Member

HerringtonDarkholme commented Apr 1, 2018 •
edited
Loading

I can reproduce the problem in 0.11.7. But I cannot reproduce it in master.

It should be fixed in 19e2959

The problem is previously we use getText to get source file content, but it skips all padding whitespace with which we replace template/style. Thus lookup went wrong. The fix is quite simple: using getFullText solves the problem.

@HerringtonDarkholme
Copy link
Member

BTW, findReferences should also have the same location lookup. I will fix it later.

@HerringtonDarkholme HerringtonDarkholme mentioned this issue Apr 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix get references HerringtonDarkholme/vetur
2 participants
@DanielRosenwasser @HerringtonDarkholme