Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home's features link attribute can't accept assets as destination #3110

Closed
4 tasks done
tassoman opened this issue Oct 20, 2023 · 0 comments · Fixed by #3114
Closed
4 tasks done

home's features link attribute can't accept assets as destination #3110

tassoman opened this issue Oct 20, 2023 · 0 comments · Fixed by #3114
Labels
bug Something isn't working theme Related to the theme

Comments

@tassoman
Copy link

Describe the bug

If I try to set an asset document as featured link, destination gets rewritten as .html

Reproduction

  1. build a vitepress site
  2. create a page having layout: home
  3. add features attribute
  4. add a feature, like this
features:
  - title: my feature
    details: my description
    link: ./myfile.pdf
  1. see: broken link ./myfile.pdf.html

Expected behavior

link should remain ./myfile.pdf

System Info

System:
    OS: Linux 5.15 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (8) x64 Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz
    Memory: 6.81 GB / 7.65 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 21.0.0 - ~/.nvm/versions/node/v21.0.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v21.0.0/bin/yarn
    npm: 10.2.1 - ~/.nvm/versions/node/v21.0.0/bin/npm
  npmPackages:
    vitepress: ^1.0.0-rc.22 => 1.0.0-rc.22

Additional context

No response

Validations

@tassoman tassoman added the bug: pending triage Maybe a bug, waiting for confirmation label Oct 20, 2023
@brc-dd brc-dd added bug Something isn't working theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Oct 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants