Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not use husky hooks #1222

Closed
gjuchault opened this issue May 4, 2018 · 6 comments
Closed

Can not use husky hooks #1222

gjuchault opened this issue May 4, 2018 · 6 comments

Comments

@gjuchault
Copy link

Version

3.0.0-beta.6

Steps to reproduce

vue create project
cd project
yarn add husky

Test hooks


It could be nice to document that @vue/cli-service is using yorkie for some lint, and a guide to add custom hooks

@yyx990803
Copy link
Member

Yeah, yorkie does the same thing with husky. Use "gitHooks" instead of "husky", and use dash delimited hook names.

@gjuchault
Copy link
Author

I did use yorkie at the end (note that the next version of husky does kinda the same as yorkie - moving from scripts to husky, pre-commit instead of precommit)
The thing is, I had to check in my .git/hooks/pre-commit, then yarn why yorkie to find out.

It would be cool to have a line in the documentation :)

@yyx990803
Copy link
Member

Yeah, the docs is still WIP, we will have lots of things to add when we reach RC.

@ghost
Copy link

ghost commented Sep 16, 2019

can there be an update to move Vue-CLI to support Husky? i noticed Yorkie has not been updated since late 2018

@AndreiSoroka
Copy link
Contributor

@yyx990803
I agree with the comment above.
P.s. Husky is supporting a project in a subdirectory, but Yorkie doesn't.

@aenlr
Copy link

aenlr commented Oct 24, 2019

@yyx990803
I agree with the comment above.
P.s. Husky is supporting a project in a subdirectory, but Yorkie doesn't.

Agreed. Also missing subdirectory project support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants