feat(compiler-sfc): support transforming asset urls with full base url. #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldenning
commented
Oct 23, 2020
| ) | ||
| attr.value.content = | ||
| host + | ||
| (path.posix || path).join(basePath, url.path + (url.hash || '')) |
There was a problem hiding this comment.
path.join() does not work well with full URLs, which is why I'm prepending host here and only joining the path portion of the url.
// Notice how path.join() strips the second slash from http://
// This is the problem that is solved by this pull request.
path.join("http://localhost:3000/src/assets", "logo.png") === 'http:/localhost:3000/src/assets/logo.png')
joeldenning
commented
Oct 23, 2020
| "import { createVNode as _createVNode, openBlock as _openBlock, createBlock as _createBlock } from \\"vue\\" | ||
|
|
||
| export function render(_ctx, _cache) { | ||
| return (_openBlock(), _createBlock(\\"img\\", { src: \\"http://localhost:3000/src/logo.png\\" })) |
There was a problem hiding this comment.
Notice the fully qualified URL for the img src - this was previously not possible when using options.base, as far as I could tell
|
It's common to omit protocol in assets. Can you add a test case for |
joeldenning
commented
Oct 24, 2020
| @@ -35,5 +35,5 @@ export function parseUrl(url: string): UrlWithStringQuery { | |||
| function parseUriParts(urlString: string): UrlWithStringQuery { | |||
| // A TypeError is thrown if urlString is not a string | |||
| // @see https://nodejs.org/api/url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost | |||
| return uriParse(isString(urlString) ? urlString : '') | |||
| return uriParse(isString(urlString) ? urlString : '', false, true) | |||
There was a problem hiding this comment.
The true here is necessary to correctly handle URLs that include hostname but not protocol, for example //localhost
|
@znck good catch - adding that test revealed a bug. I have pushed a new commit with the test and the corresponding fix. |
znck
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows for fully qualified URLs (including protocol, host, and port) to be provided as
options.basewhen transforming template asset urls. Previously, passing full URLs was unsupported, sincepath.join()does not work well with full URLs.This is my first contribution to vue 3 and I'm not sure if the lack of support for this was intentional or not. I am looking forward to your feedback.