Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error caused by the same path and alias of RouteConfig #2462

Closed
wants to merge 4 commits into from

Conversation

chenfengjw163
Copy link
Contributor

No description provided.

@chenfengjw163
Copy link
Contributor Author

chenfengjw163 commented Nov 1, 2018

#2461

if (!pathMap[record.path]) {
pathList.push(record.path)
pathMap[record.path] = record
}

if (route.alias !== undefined) {
if (route.alias === path) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warn should only appear on dev mode. Also could you add a test for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have already added

posva added a commit that referenced this pull request Jul 9, 2019
@posva
Copy link
Member

posva commented Jul 9, 2019

Hey, I added a check for arrays too and directly merged to dev. Thank you!

@posva posva closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants