Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeRouteEnter callbacks trigger in opposite order for nested routes #2761

Labels
Projects

Comments

@posva
Copy link
Member

posva commented May 8, 2019

Version

3.0.3

Reproduction link

https://jsfiddle.net/posva/jr8wgc4u/

Steps to reproduce

  • click on the last link /foo/a/d/c
  • check logs

What is expected?

beforeEnter order to be the same as beforeRouteEnter, from parent to child: Foo, NestedOne, NestedTwo

What is actually happening?

The order in beforeRouteEnter is backwards


I should also check if the same happens outside of the callback

@posva posva added the bug label May 8, 2019
@zrh122
Copy link
Contributor

zrh122 commented May 8, 2019

@posva, i think #2738 fixes it.

@posva
Copy link
Member Author

posva commented May 8, 2019

Thanks for pointing out, I didn't check, but I didn't want to forget about this

@posva posva added this to Long term road (high prio, low complex) in Longterm May 8, 2019
@posva posva closed this as completed in 8ac478f May 9, 2019
@posva posva moved this from Long term road (high prio, low complex) to Done in Longterm May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment