-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router-view): add passing props to inactive component #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrh122
force-pushed
the
fix-keepalive-props
branch
from
June 15, 2019 13:55
b58940c
to
a302a33
Compare
@zrh122 Could you give this a new look and fix the merge conflicts please? |
zrh122
force-pushed
the
fix-keepalive-props
branch
from
January 14, 2020 13:08
a302a33
to
b2429ab
Compare
posva
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was so fast! Thank you for the PR, it looks good, I refactored things a little bit (mostly naming) and added a few tests
Thanks so much 👏. |
This was referenced Mar 1, 2020
This was referenced Mar 19, 2020
This was referenced Mar 28, 2020
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add passing
props
to inactive component. it closes #2301.